Using pip to build wheels, a.k.a. pep517 bootstrap

[botant]

Hello, @ionelmc any plans to move forward with support of pep517 / pip? I'd be willing to help with that, if we know the direction... Thanks!

[ionelmc]

If you're willing to make a PR with that I'd be glad, I didn't have time to do it.

[botant]

Cool, I'll have a go in the next few days.

[botant]

Hi Ionel,

Apologies for not coming back sooner. Last few months have been crazy.

May I ask a question about the patch decorator?

@contextmanager
def patch(obj, attr, value):
    original = getattr(obj, attr)
    setattr(obj, attr, value)
    try:
        yield
    finally:
        getattr(obj, attr, original)

The call to getattr inside finally, is that supposed to setattr?

[ionelmc]

Oh wow how did I miss that. Yep, it should be setattr.

[botant]

I can add the fix to the PR created today, if that is okay with you.

On Sun, 28 Jun 2020, 18:51 Ionel Cristian Mărieș, notifications@github.com wrote:

Oh wow how did I miss that. Yep, it should be setattr.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ionelmc/tox-wheel/issues/4#issuecomment-650799885, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMJFPCURX4NWMUKHDRH54DRY57KDANCNFSM4KX2J5KA .

[ionelmc]

Please do.

[ionelmc]

Just released 0.5.0.

[daa]

Great! Thank you very much.