treat isolated_build as an alias for wheel_pep517

ionelmc / tox-wheel

A Tox plugin that builds and installs wheels instead of sdist. Note that this plugin is obsolte as tox 4.0 already has wheel support.

BSD 2-Clause "Simplified" License

23 stars 9 forks source link

treat isolated_build as an alias for wheel_pep517 #6

Closed graingert closed 4 years ago

graingert commented 4 years ago

the isolated_build flag is documented as enabling pep517 already: Activate isolated build environment. tox will use a virtual environment to build a source distribution from the source tree. For build tools and arguments use the pyproject.toml file as specified in PEP-517 and PEP-518.

ionelmc commented 4 years ago

Why did I put that warning I wonder ...

ionelmc commented 4 years ago

Alright. I guess I put it there because isolated_builds don't work with the legacy wheel building, nor it makes sense.

ionelmc commented 4 years ago

Actually, now that I think a bit this is wrong - having a plugin installed shouldn't change behavior if there wasn't any opt-in the configuration (eg: wheel=true). Might need to revert this to prevent surprising behavior. @graingert

graingert commented 4 years ago

@ionelmc this doesn't trigger without wheel=True