search

ionic-enterprise / ionic-training-decks

The Customer Success team's enterprise level training decks
MIT License
24 stars 6 forks source link

fix(ionic-weather): Making some updates to Step 08 of the weather app #21

Closed bryplano closed 5 years ago

bryplano commented 5 years ago

Changes

kensodemann commented 5 years ago

In general, you may want to revisit this after I am done adding unit testing and whatnot to the training, as almost everything is currently in the process of being rewritten. I have also been cutting way back on the amount of extraneous information that doesn't really belong here.

Basically, these things should not be complete guides and should not stand on their own, but should be supplemental to the class experience itself. I am starting to believe the original ones I had written contained way too much information on their own, to the point where you could use them without the actual training.

The part that is bad there, is it gets really repetitive in the training itself.

kensodemann commented 5 years ago

Looking at the re-write I have going, this is now step-10... So rather than merge, I am going to roll the applicable changes from here into there as I go.

bryplano commented 5 years ago

@kensodemann - Thanks for the updates and reading through this. Let me know if you want me to close this out or leave it open for now, entirely up to you in the context of the rewrite :)

bryplano commented 5 years ago

Closing this out since Ken made some of the changes in his branch :)