ionic-team / angular-toolkit

Angular Schematics and Builders for `@ionic/angular` apps.
MIT License
69 stars 30 forks source link

bug: Ionic CLI does not add display.css in Angular MonoRepo #415

Closed joelmeaders closed 3 years ago

joelmeaders commented 3 years ago

Bug Report

Ionic version: [x] 5.x

Current behavior: When working in a monorepo and adding a new project, the ionic CLI configures angular.json with all style-sheets except display.css

Expected behavior: It should also add:

"styles": [
              "santashop-admin/src/global.scss",
               ...
               {
                        "input": "node_modules/@ionic/angular/css/display.css"
                },
                ...

Steps to reproduce: Angular 11, Ionic 5.4.4, Ionic CLI 6.12.2 Unfortunately I forgot the commands I used to set up the projects but angular.json was set up automatically using those commands. I found them at two different places in your documentation.

Ionic info:

Ionic:

   Ionic CLI                     : 6.12.2 (C:\Users\joelm\AppData\Roaming\npm\node_modules\@ionic\cli)
   Ionic Framework               : @ionic/angular 5.4.4 (C:\_dev\SantasWorkshop\node_modules\@ionic\angular)
   @angular-devkit/build-angular : 0.1100.1 (C:\_dev\SantasWorkshop\node_modules\@angular-devkit\build-angular)
   @angular-devkit/schematics    : 11.0.1 (C:\_dev\SantasWorkshop\node_modules\@angular-devkit\schematics)
   @angular/cli                  : 11.0.1 (C:\_dev\SantasWorkshop\node_modules\@angular\cli)
   @ionic/angular-toolkit        : 3.0.0 (C:\_dev\SantasWorkshop\node_modules\@ionic\angular-toolkit)

Utility:

   cordova-res : 0.15.2
   native-run  : 1.2.2

System:

   NodeJS : v13.8.0 (C:\Program Files\nodejs\node.exe)
   npm    : 6.13.6
   OS     : Windows 10
mhartington commented 3 years ago

This needs to be fixed in ionic/angular proper. Will send PR shortly.