search

ionic-team / app-wizard-issues

1 stars 0 forks source link

Icon not used in React project? #1

Closed mirkonasato closed 4 years ago

mirkonasato commented 4 years ago

Describe the bug

The start wizard asks to Pick an icon, but that icon doesn't seem to be used anywhere in the generated project.

To Reproduce Steps to reproduce the behavior:

Go to the start wizard, pick an icon, select React as the framework, create app, fetch the project with ionic start --start-id ...

Open the project. There's a resources folder with icon.png and splash.png. But public/manifest.json references favicon.png and icon.png in public/assets/icon and they both show the Ionic logo.

After running ionic capacitor add android, the Android project uses the Capacitor logo for all launcher icons and splash screen.

Expected behavior The selected icon should be used everywhere, as favicon, mobile app icons and splash screens.

This is using the @ionic/cli v6.5.0.

mlynch commented 4 years ago

Thanks. You need to run the cordova-res command to generate the icons from the resources folder after you've added your platforms. I know it's confusing, we are working to make this more seamless.

mirkonasato commented 4 years ago

Oh, I thought cordova-res was just for Cordova given the name, but it does work with Capacitor as well. Good to know!

mlynch commented 4 years ago

Yea we will be changing that soon! Thanks, going to close