search

ionic-team / capacitor-docs

https://capacitorjs.com/docs
Apache License 2.0
25 stars 223 forks source link

docs: Update background-runner.md #289

Closed Kuldeepdev closed 5 months ago

Kuldeepdev commented 5 months ago

Fixed grammatical error from ran to run

vercel[bot] commented 5 months ago

@Kuldeepdev is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

jcesarmobile commented 5 months ago

thanks for the PR, but plugin docs are generated from the plugin's README.md file, so should be changed there https://github.com/ionic-team/capacitor-background-runner/blob/main/packages/capacitor-plugin/README.md#configuring-background-runner

In fact it's now part of the autogenerated part that gets generated from the definitions file, so should be changed in the definitions file and then run a build so the README.md file gets the changes https://github.com/ionic-team/capacitor-background-runner/blob/main/packages/capacitor-plugin/src/definitions.ts#L47-L52

Kuldeepdev commented 5 months ago

Thank you @jcesarmobile ! Raised PR as per your suggestion.

Notice another issue When clicking on “Edit this page” on the Background Runner documentation page, users should be redirected to the appropriate editing interface.