ionic-team / capacitor-plugins

Official plugins for Capacitor ⚡️
486 stars 563 forks source link

bug: PushNotificationSchema on ios has 'extra' instead of 'data' #332

Closed moxaj closed 3 years ago

moxaj commented 3 years ago

Bug Report

Capacitor Version

Latest Dependencies:

@capacitor/cli: 2.4.7 @capacitor/core: 2.4.7 @capacitor/android: 2.4.7 @capacitor/ios: 2.4.7

Installed Dependencies:

@capacitor/cli: 3.0.0-beta.6 @capacitor/android: 3.0.0-beta.6 @capacitor/ios: 3.0.0-rc.0 @capacitor/core: 3.0.0-beta.6

Platform(s)

ios

Current Behavior

The PushNotificationSchema object exposed in the pushNotificationActionPerformed callback has the associated key-value pairs in its extra field.

Expected Behavior

The key-value pairs should be assigned to the data field, as in android.

Code Reproduction

See:

(The other fields seem somewhat inconsistent as well)

Other Technical Details

npm --version output: 6.14.6

node --version output: v12.18.3

pod --version output (iOS issues only): 1.10.1

vitorlopez commented 3 years ago

Please merge this 😄

vitorlopez commented 3 years ago

Thank you so much.

Do you know when this is going to be pushed to npm, or for that matter when a new capacitor RC is going to be pushed? I see there's a lot of fixes already merged to main.

Thanks again.

ionitron-bot[bot] commented 1 year ago

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of the plugin, please create a new issue and ensure the template is fully filled out.