search

ionic-team / capacitor-site

Capacitor website
https://capacitorjs.com/
MIT License
4 stars 109 forks source link

docs(android): correct permission name #441

Closed AmitMY closed 2 years ago

vercel[bot] commented 2 years ago

@AmitMY is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

jcesarmobile commented 2 years ago

Thanks for the PR, but this is just an example on how to add the ACCESS_NETWORK_STATE permission, the name is correct, INTERNET permission is already added by default on all Capacitor apps.

AmitMY commented 2 years ago

My understanding is that YOUR PERMISSIONS should include the added permissions, and it is trying to show the default file, which does indeed require the INTERNET permission

jcesarmobile commented 2 years ago

It doesn't show the default file because it has a lot of comments like <!-- other stuff --> and <!-- More stuff -->.

The default file has <!-- Permissions --> instead of <!-- Your permissions -->, which should imply that it's where you add your own permissions.

Anyway, if you think it's not clear, you can change the <!-- Your permissions --> to <!-- Permissions --> and add internet permission, but without removing the ACCESS_NETWORK_STATE permission in a separate PR.