ionic-team / capacitor-site

Capacitor website
https://capacitorjs.com/
MIT License
4 stars 109 forks source link

CDN link PWA Elements is wrong - but is different from MD? #446

Closed Tommertom closed 2 years ago

Tommertom commented 2 years ago

https://github.com/ionic-team/capacitor-site/edit/main/pages/docs/v3/web/pwa-elements.md

displays as:

<script
  type="module"
  src="https://unpkg.com/@ionic/pwa-elements@latest/dist/ionicpwaelements/ionicpwaelements.esm.jspwa-elements@latest/dist/ionicpwaelements/ionicpwaelements.esm.js"
></script>
<script
  nomodule
  src="https://unpkg.com/@ionic/pwa-elements@latest/dist/ionicpwaelements/ionicpwaelements.jspwa-elements@latest/dist/ionicpwaelements/ionicpwaelements.js"
></script>

on https://capacitorjs.com/docs/web/pwa-elements - which is an incorrect and malfunctioning CDN reference.

whereas the markdown source seems to show the proper CDN reference:

image

So, it should show like below on https://capacitorjs.com/docs/web/pwa-elements

<script
  type="module"
  src="https://unpkg.com/@ionic/pwa-elements@latest/dist/ionicpwaelements/ionicpwaelements.esm.js"
></script>
<script
  nomodule
  src="https://unpkg.com/@ionic/pwa-elements@latest/dist/ionicpwaelements/ionicpwaelements.js"
></script>
jcesarmobile commented 2 years ago

It's working fine now