ionic-team / capacitor

Build cross-platform Native Progressive Web Apps for iOS, Android, and the Web ⚡️
https://capacitorjs.com
MIT License
12.29k stars 1.01k forks source link

feat(cli)!: change telemetry from opt-in to opt-out #7714

Closed eric-horodyski closed 1 month ago

eric-horodyski commented 1 month ago

Modify telemetry such that is it opt-out instead of the current opt-in behavior:

eric-horodyski commented 1 month ago

why change the output.write to logger.msg. I don't see any visible differences between them, but on cli/src/tasks/telemetry.ts the THANK_YOU message is also written still with output.write, so for consistency I would keep output.write for both.

For some reason, output.write caps at writing 2 lines of text so I had to use logger.msg.

eric-horodyski commented 1 month ago

Two changes have been added:

  1. Use output.write() to write out the message when the user is opted-in.
  2. Retain the original messaging (from when telemetry was opt-out) to be written out when the user manually turns telemetry on.