ionic-team / capacitor

Build cross-platform Native Progressive Web Apps for iOS, Android, and the Web ⚡️
https://capacitorjs.com
MIT License
12.29k stars 1.01k forks source link

chore: run dispatch-release.yaml in 6.x branch #7736

Closed jcesarmobile closed 1 month ago

jcesarmobile commented 1 month ago

I've created a 6.x branch in ionic-team/capacitor-swift-pm for Capacitor 6, make the 6.x Capacitor branch run the workflow in 6.x branch too

Steven0351 commented 1 month ago

This shouldn't be needed, this workflow runs when a tag is pushed, not when a commit is made to main. The target repo checks out the version specified and builds that, there isn't anything specific to any version of capacitor in that repo.

jcesarmobile commented 1 month ago

Both Capacitor and Capacitor plugins are pointing to "main", which at the moment is Capacitor 7 alpha 1, I've created a 6.x branch in ionic-team/capacitor-swift-pm pointing to latest 6.x release and sent PRs to Capacitor and Capacitor Plugins 6.x branch to make them use 6.x branch instead of main, but we need that whenever we publish a new 6.x version it's published on the 6.x branch, not in main branch, and I though this change would do that, but not sure how ionic-team/capacitor-swift-pm publishing works and if this change will have that effect. If this doesn't make the publish action in ionic-team/capacitor-swift-pm repo to publish on main, we will have to change the action code in 6.x branch to publish in 6.x branch.

https://github.com/ionic-team/capacitor/pull/7737 https://github.com/ionic-team/capacitor-plugins/pull/2221

Steven0351 commented 1 month ago

A simpler approach would be to just have a version range in the Package.swift to be 6.0.0 < 7.0.0. I'm not sure why every Package.swift was just pointing directly to main.

Steven0351 commented 1 month ago

@markemer do you know why the Package.swift's have been pointing to main?

jcesarmobile commented 1 month ago

Ok, will update to use ranges or from and delete the 6.x branch from ionic-team/capacitor-swift-pm repo