search

ionic-team / cordova-plugin-ionic-keyboard

Keyboard Plugin for Cordova
Other
191 stars 177 forks source link

Fix layout overflowing to navigation bar & blackbar issue when keyboard is active #145

Open mloremi opened 4 years ago

mloremi commented 4 years ago

this is a fix for these bugs: https://github.com/ionic-team/cordova-plugin-ionic-keyboard/issues/117 https://github.com/ionic-team/cordova-plugin-ionic-keyboard/issues/132

rmartin94 commented 4 years ago

Is there a way to install this pull request and try it out? I can't make it work by adding the file changes and re-building the app in android

jakob-p commented 3 years ago

The change in Line 140 return r.bottom;

makes the view height to small in my app, if i revert it back to

return r.bottom - r.top;

this pull request fixes the resizeOnFullScreen issue mentioned in #117 for me 👍

boomfly commented 3 years ago

It working. Fix black bar above keyboard & soft buttons overlap webview. +1 to merge

ebhsgit commented 3 years ago

@jakob-p Are you using full screen mode?

The changes in this PR seems to assume the content is in full screen mode.

This assumption is incorrect. Because some pages in an app may not be in full screen mode. And some users of the plugin may incorrectly set the resizeOnFullScreen and not use full screen mode at all.

I made my PR separately, and is very similar to the changes in this PR. My PR checks for full screen mode and applies the appropriate height.

Anyway, try out changes in my PR #156, and let me know if it fixes your issue.