search

ionic-team / cordova-plugin-ionic-keyboard

Keyboard Plugin for Cordova
Other
191 stars 177 forks source link

Incorrect Height Value on some Android devices #157

Open kensodemann opened 3 years ago

kensodemann commented 3 years ago

On certain devices (Dallas helped me test it on his Galaxy S10 as I could not replicate it on the Pixel devices I have), the @ionic-enterprise/keyboard plugin will report the height of the keyboard as one value, and the Capacitor plugin will report a different value.

For Dallas it was: Cordova: 333 Capacitor: 375

The customer had similar results. In both cases, the larger Capacitor number appears to be the correct value.

To replicate this, I created the following app: https://github.com/kensodemann/test-keyboard-height

There are two useful branches here:

cordova: Cordova app, uses @ionic-enterprise/keyboard

capacitor: Capacitor app, uses Capacitor Keyboard API plugin

mattylight22 commented 3 years ago

@kensodemann have you figured anything out with this. I’m having an identical problem.

kensodemann commented 3 years ago

@mattnick89 - there is a premier version of this plugin and it has been fixed there. Apparently, the same PR has not made its way in to the community version of the plugin, though it is marked as a future TODO (see the projects to the right). That team, however, is currently focused heavily on getting Capacitor v3 out the door.

The PR for the premier plugin was based on the following PR for Capacitor: https://github.com/ionic-team/capacitor/pull/2924