search

ionic-team / cordova-plugin-ionic-keyboard

Keyboard Plugin for Cordova
Other
193 stars 178 forks source link

Can be used with a Ionic V1 project? #38

Closed aroncal closed 5 years ago

aroncal commented 6 years ago

Hi,

I was redirected here from the cordova-plugin-keyboard project, that I have used in my Ionic v1 project so far. Now, I'm updating Cordova to a newer version (8), and trying to update as much libraries/plugins as possible to newest versions without breaking compatibility, I realized that the mandatory cordova-plugin-ionic-webview for this to work, seems to be incompatible with Ionic v1 (deviceready is not fired in the App)... Should I stick to cordova-plugin-keyboard in my project?

Thanks!

pliablepixels commented 5 years ago

I'd appreciate a note from the ionic-devs too. Many of us have ionic-v1 deployments - I'm facing odd view bounce issues on iOS with this plugin. I can't use WKWebview due to its CORS restrictions.

mlynch commented 5 years ago

I'd stick with ionic-plugin-keyboard in that case. This plugin was designed for 2.x and newer

abhijithp commented 5 years ago

ionic-plugin-keyboard plugin has a lot of issues in ios 12.

SuperStar518 commented 5 years ago

Install the latest version of this plugin, then you're OK. I'm working on my ionic v1 project, too.

Defcon0 commented 5 years ago

@robjs827 Do you mean ionic-plugin-keyboard or cordova-plugin-ionic-keyboard?

@abhijithp I don't have any issues with ionic-plugin-keyboard on iOS 12. Which are you having? I only tested on iPhone XR, not iPad.

geshub commented 5 years ago

This plugin can't be used with v1 because 'cordova.plugins.Keyboard' references are harcoded in the source code. So the function keyboardHasPlugin() will always returns false. But the v1 events like native.keyboardhide and native.keyboardshow are compatibles with the last version of this plugin. So you'll have to keep the deprecated plugin if you've got a production v1 app. I really look forward to move to react native and get ride of all the unsolvable v1 problems ....

jcesarmobile commented 5 years ago

The plugin is really framework agnostic, so it shouldn't matter which framework you use, but if Ionic 1 relies on some functions/events from ionic-plugin-keyboard, then those things won't work as this plugin doesn't provide them. Going to close as it's not really this plugin's fault.

FWagner13 commented 5 years ago

@robjs827 Do you mean ionic-plugin-keyboard or cordova-plugin-ionic-keyboard?

@abhijithp I don't have any issues with ionic-plugin-keyboard on iOS 12. Which are you having? I only tested on iPhone XR, not iPad.

There is a huge webkit issue with ionic-plugin-keyboard on iOS 12 when built with Xcode 10+. Take a look: https://github.com/apache/cordova-ios/issues/417