search

ionic-team / cordova-plugin-ios-keychain

Apache Cordova (PhoneGap) plugin
Other
62 stars 44 forks source link

Add Keychain reference on window object #1

Closed jacquesdev closed 8 years ago

jacquesdev commented 8 years ago

I am using the following plugin: ng-persist , which uses shazron's original KeychainPlugin as a dependency.

I am trying to swap out this fork instead for shazron's original KeychainPlugin, and it looks like the original plugin adds a reference to the Keychain object on the window object here. This reference is used in ng-persist, and so using the current fork doesn't work because it can't find the Keychain object (on the window object).

If you could add this reference - or suggest an alternative fix that would be great!

jacquesdev commented 8 years ago

@mlynch - is this something you would be able to do by any chance?

mlynch commented 8 years ago

I have that same line in here: https://github.com/driftyco/cordova-plugin-ios-keychain/blob/master/plugin.xml#L18

What's not working for you guys?

jacquesdev commented 8 years ago

Hmm, ok sorry I did not see that before. Basically when I use this plugin with ng-persist, I get the error that window.Keychain does not exist, whereas with the original plugin it does not seem to be a problem, but could be part of my setup.

I will play around with it some more to see if I can figure it out.

HeyHugo commented 7 years ago

I believe I'm facing the same problem with ng-persist plugin.

Object is not a constructor (evaluating 'new window.Keychain')

The piece of code using $persist is wrapped in $ionicPlatform.ready so everything should be loaded at this point.

jacquesdev commented 7 years ago

@HeyHugo - please see my comments here: https://github.com/AlexDisler/ng-persist/issues/6

Also, I have added the PR as mentioned: https://github.com/AlexDisler/ng-persist/issues/7