ionic-team / cordova-plugin-ios-keychain

Apache Cordova (PhoneGap) plugin
Other
62 stars 44 forks source link

iCloud enable/disable option #2

Closed okonon closed 7 years ago

okonon commented 8 years ago

Is there a way to enable / disable iCloud Keychain sync?

jacquesdev commented 8 years ago

@mlynch - I believe the changes were done after your fork, as part of this commit: https://github.com/shazron/KeychainPlugin/commit/4399889816bd5898f0359dc85a5aae2f9f793ea7

Could be quick to add this option here?

johnreitano commented 8 years ago

I need this functionality too. Would it be possible to merge in those changes?

mlynch commented 8 years ago

Got it, I'll look into how I might do this with the keychain engine underneath this

mlynch commented 8 years ago

Hey, just pushed a branch which (in theory) adds support for iCloud. Mind testing this and let me know if it's working for you? This adds a new flag to set which is a boolean to sync or not sync:

https://github.com/driftyco/cordova-plugin-ios-keychain/tree/wip-icloud

atsats commented 7 years ago

My preliminary testing indicates that that the new flag added to the set function (which controls whether the key gets synched to iCloud) works as designed when the value is false.

tommykk commented 7 years ago

Hey, is there any chance of this getting in soon? I could really do with this feature!

mlynch commented 7 years ago

Hi @tomkeble, it's available now. Just install the plugin from this repo and you're golden