search

ionic-team / create-capacitor-plugin

Create a new Capacitor plugin ⚡️
Other
79 stars 11 forks source link

feat: Add example test app to template for better DX #64

Closed thomasvidas closed 3 years ago

thomasvidas commented 3 years ago

Fixes #53

jcesarmobile commented 3 years ago

Honestly I don't see the point of adding almost one hundred files to this repository that are already part of create-capacitor-app repository and we would need to remember to maintain in sync in both places.

Maybe we can make the tooling run some commands to do the same but without being part of the repository. i.e

npm init @capacitor/app example (would require changes in create app because at the moment it only takes the folder name, but prompts for app name and package name)
cd example
npm install ../
code that replaces the default index.html with a custom index.html and that uses the echo method of the plugin
npx cap sync
something else?
thomasvidas commented 3 years ago

Now this relies on npm init @capacitor/app command rather than hard-coding this. However, this PR is blocked by this issue in @capacitor/create-app, which I'm working on now

thomasvidas commented 3 years ago

PR Here: https://github.com/ionic-team/create-capacitor-app/pull/10. Needs to be published on npm before this PR would work as expected though

jcesarmobile commented 3 years ago

this is still missing:

Also, I think we should add basic functionality to the app, add some input and a button that calls the default echo method of the plugin. At the moment the app logic lives in capacitor-welcome.js file, so we could have a file as template that replaces the capacitor-welcome.js and adds that minimal functinality.

otherwise we are just adding a new capacitor app that has nothing to do with the plugin