bug: Ionic 8 doesn't work with this cli

qwe12e commented 6 months ago

Prerequisites

[X] I agree to follow the Code of Conduct.
[X] I have searched for existing issues that already report this problem, without success.

Codemod version

0.3.0

Current Behavior

I'm trying to use this migration tool to use standalone component. I recently upgraded my app version to "@ionic/angular": "^8.0.0", but when I look at this cli code I can see that you guys looking at if major < 7 if minor < 5

and of course in the new version we have a minor version of 0 so we can't continue

Expected Behavior

cli should work with ionic 8

Steps to Reproduce

create an ionic angular app with ionic 8
run npx @ionic/angular-standalone-codemods

Code Reproduction URL

No response

Additional Information

No response

FurbyX92 commented 6 months ago

if (majorVersion < 7) {
  logVersionError();
  return false;
}
// only need to add if is major v7 then compare with minor 5.
if (majorVersion == 7 && minorVersion < 5) {
  logVersionError();
  return false;
}

ionitron-bot[bot] commented 4 months ago

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of the codemods, please create a new issue and ensure the template is fully filled out.

ionic-team / ionic-angular-standalone-codemods