ionic-team / ionic-app-lib

The library used for using ionic apps - consumed by the CLI and the GUI
44 stars 79 forks source link

Move the HTTP Proxy code to a single function inside utils.js #122

Closed icyflame closed 8 years ago

icyflame commented 8 years ago

Right now, the line var proxy = process.env.proxy || process.env.HTTP_PROXY || null is repeated across the module. Also, the case is inconsistent in a lot of places. I can move all of the occurences into utils.js and call a function from there at the top of each file (such upload.js and refer to that for the rest of the file)

I will work on this, if you would be interested in this patch.