Get the proxy from a single function inside Utils instead of repeating code everywhere

ionic-team / ionic-app-lib

The library used for using ionic apps - consumed by the CLI and the GUI

44 stars 79 forks source link

Closed icyflame closed 8 years ago

icyflame commented 8 years ago

Added a single test for Utils.getProxy
Please tell me how to spoof the environment variable from inside the spec, so that I can write the other test where the function returns a valid proxy

Fixes #122

icyflame commented 8 years ago

The failure of this test is because the test has been run from icyflame/ionic-app-lib, and this repository does not have a coveralls.io account.

icyflame commented 8 years ago

ping @jthoms1 and @tlancina Hey! Can you please have a look at this patch? :slightly_smiling_face: