search

ionic-team / ionic-app-lib

The library used for using ionic apps - consumed by the CLI and the GUI
44 stars 79 forks source link

Add regex to parse cordova version to account for telemetry warning #141

Closed snewell92 closed 7 years ago

snewell92 commented 7 years ago

Would fix issue drifty/ionic-cli#1376

Might be a good idea to add tests if all of allEnvironmentInfo's data should be semantic version numbers; semver.valid could be used.

snewell92 commented 7 years ago

Ideally Cordova would just output its semver number, so I added an issue in Cordova's jira issue tracker here.

snewell92 commented 7 years ago

I'll try to land a PR in cordova's CLI repo instead of here. Closing this as ionic shouldn't have to specially treat -v output.

Although using semver to test validity as a unit test is still a pretty good idea! 😉