search

ionic-team / ionic-app-scripts

App Build Scripts for Ionic Projects
http://ionicframework.com/
MIT License
608 stars 302 forks source link

locationStrategy: 'path' deeplinks #1545

Open JoeMeeks opened 4 years ago

JoeMeeks commented 4 years ago

Short description of what this resolves:

enable 404 redirects in http-server.ts to allow locationStrategy: 'path' to work with deeplinks when running ionic:serve per https://github.com/ionic-team/ionic/issues/10565#issuecomment-307420460

Changes proposed in this pull request:

Fixes: # "Cannot GET /[deeplink-path]" no longer occurs and redirects work not using hash navigation

Pyav123 commented 4 years ago

Hello @JoeMeeks I was also facing same problem and your solution is working , but when will it be available for us to use ? As I have added that line of code manually in node module

JoeMeeks commented 4 years ago

@Pyav123 I wish I knew. I submitted this PR for review 3 months ago.

liamdebeasi commented 4 years ago

Hey there! Most of the team's efforts are focused on supporting Ionic Framework v5. As a result, it is unlikely this PR will get reviewed/merged. You are more than welcome to fork ionic-app-scripts and apply the patch that way. Thanks!