search

ionic-team / ionic-app-scripts

App Build Scripts for Ionic Projects
http://ionicframework.com/
MIT License
608 stars 304 forks source link

Sourcemaps aren't updated properly after source code changes #595

Closed jgw96 closed 7 years ago

jgw96 commented 7 years ago

From @beylkhanovdamir on December 17, 2016 4:40

Ionic version: (check one with "x") [ ] 1.x [ x] 2.x

I'm submitting a ... (check one with "x") [ x] bug report [ ] feature request [ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:

I run my ionic app by ionic serve command. after this I want to make a some changes in my source code and then I'm saving my changes, in result, starts the build process of project by ionic-appscripts and page is refreshing. In result, my sourcemaps files doesn't updated or they missing in Source control (in Google chrome dev tools). to fix this issue, I must stop the ionic serving process, and run it again Expected behavior:

after saving any changes in my source code, sourcemaps in Source control must be updated according with my changes properly

Ionic info:

Cordova CLI: 6.3.1
Ionic CLI Version: 2.1.14
Ionic App Lib Version: 2.1.7
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v6.9.1
Xcode version: Not installed

app-scripts": "^0.0.46",

Copied from original issue: driftyco/ionic#9680

jgw96 commented 7 years ago

From @graphefruit on December 17, 2016 10:52

@beylkhanovdamir Update your appscripts to the latest actually 0.0.47 and have a look if the issue still exists

jgw96 commented 7 years ago

From @dylanvdmerwe on December 17, 2016 13:51

https://github.com/driftyco/ionic-app-scripts/blob/master/CHANGELOG.md

jgw96 commented 7 years ago

From @beylkhanovdamir on December 19, 2016 8:34

@graphefruit @dylanvdmerwe thx, I'll try

danbucholtz commented 7 years ago

Does this issue still exist?

Thanks, Dan

dbeylkhanov commented 7 years ago

@danbucholtz let me check

royipressburger commented 7 years ago

@danbucholtz I have a similar issue with 0.0.48. Change code on any .ts file causes the browser to refresh but on dev tool it doesn't change.

dbeylkhanov commented 7 years ago

@danbucholtz @jgw96

I updated ionic-app-scripts to latest v1.0 - now everything works fine thx. close issue

dbeylkhanov commented 7 years ago

@danbucholtz @jgw96

However, source maps (with *.ts extension) are not showing when I run app on android device, So I cannot debug it on device via Chrome=/

it's dev tools view in Chrome:

image

it's my system info:

ionic-app-scripts v1.0 Cordova CLI: 6.3.1 Ionic Framework Version: 2.0.0-rc.5 Ionic CLI Version: 2.2.1 Ionic App Lib Version: 2.2.0 Ionic App Scripts Version: 1.0.0 ios-deploy version: Not installed ios-sim version: Not installed OS: Windows 10 Node Version: v6.9.1 Xcode version: Not installed

Also I'm added the next section to my package.json but it is not helped me:

"config": {
    "ionic_bundler": "rollup",
    "ionic_source_map_type": "source-map"
  },