search

ionic-team / ionic-framework

A powerful cross-platform UI toolkit for building native-quality iOS, Android, and Progressive Web Apps with HTML, CSS, and JavaScript.
https://ionicframework.com
MIT License
51.14k stars 13.5k forks source link

ionic-google-maps & ionic-image-upload #1442

Closed pbrain19 closed 10 years ago

pbrain19 commented 10 years ago

Seems to me that 3rd party plugins/directives have a strong issue being integrated easily. 2 important components that I use in my apps is angular-google-maps (http://angular-google-maps.org/api) and Cropme (https://github.com/standup75/cropme). Both seem to experience issues that are beyond repair. I wanted to know if there were plans to make ionic friendly directives for these 2 important components.

mlynch commented 10 years ago

What are the issues? Could be bugs in those libraries. Stack traces, screenshots, etc help. Thanks!

Sent from my iPhone

On May 19, 2014, at 8:09 PM, Paul Garcia notifications@github.com wrote:

Seems to me that 3rd party plugins/directives have a strong issue being integrated easily. 2 important components that I use in my apps is angular-google-maps (http://angular-google-maps.org/api) and Cropme (https://github.com/standup75/cropme). Both seem to experience issues that are beyond repair. I wanted to know if there were plans to make ionic friendly directives for these 2 important components.

— Reply to this email directly or view it on GitHub.

adamdbradley commented 10 years ago

Does it have to do with the clicks not working? Have you wrapped the 3rd party plugins with <div data-tap-disabled="true">:

http://ionicframework.com/docs/api/page/tap/

pbrain19 commented 10 years ago

Yes I applied this attribute. Here is a sample version of the app you can run... make an account to go to the cropme secion. You must make an event near you to be able to click the marker.

http://shielded-hamlet-4180.herokuapp.com/#/app/eventmaps

I spoke with the writers of Cropme and Angular-google-maps and they would probably need to rewrite their directives using the ionic framework gesture control. For now I think they will be using ng-touch.

It would be awesome to see a set of 3rd party directives that are frequently used made just for ionic....

thanks

pbrain19 commented 10 years ago

Or atleast a ngTouch fallback

pbrain19 commented 10 years ago

Maybe for the Cropme we can have a boolean attribute that can decide if use native vs web. Should I start a project of this sort or is someone already tackling these issues? IDK what to call the project ionic-ui... lol?

perrygovier commented 10 years ago

Hey @pbrain19, we may add a sort of plugin/extension directory for Ionic. This would be a good addition to that. Were you able to get this working?

pbrain19 commented 10 years ago

I made a work around for angular google maps and as far as the image upload it still a hassle.. Even using the Jcrop library the touch events don't fire. Then I tried Jr-crop.. Same issue... Kinda stuck. I requested a tutorial for an image crop tool so I will be waiting for that.

perrygovier commented 10 years ago

Hey @pbrain19, Angular is known to be a little heavy handed when it comes to playing with other libraries. You may want to take a look at ng-cordova for examples of how get other JS to play well with Angular. Usually, the best way is through a service.

perrygovier commented 10 years ago

Closing since it's not part of core ionic, keep us posted though.

ionitron-bot[bot] commented 6 years ago

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.