ionic-team / ionic-framework

A powerful cross-platform UI toolkit for building native-quality iOS, Android, and Progressive Web Apps with HTML, CSS, and JavaScript.
https://ionicframework.com
MIT License
50.93k stars 13.51k forks source link

v4: ion-list has no bottom lines, properties lines seems not work as expected #14689

Closed mburger81 closed 6 years ago

mburger81 commented 6 years ago

Bug Report

Describe the Bug Having a simple ion-list does not show lines on bottom of every item, also your simple example in documentation doesn't show lines

image

     <ion-list>
          <ion-item>Pokémon Yellow</ion-item>
          <ion-item>Super Metroid</ion-item>
          <ion-item>Mega Man X</ion-item>
          <ion-item>The Legend of Zelda</ion-item>
          <ion-item>Pac-Man</ion-item>
          <ion-item>Super Mario World</ion-item>
          <ion-item>Street Fighter II</ion-item>
          <ion-item>Half Life</ion-item>
          <ion-item>Portal</ion-item>
          <ion-item>Final Fantasy VII</ion-item>
          <ion-item>Star Fox</ion-item>
          <ion-item>Tetris</ion-item>
          <ion-item>Donkey Kong III</ion-item>
          <ion-item>Goldeneye 007</ion-item>
          <ion-item>Doom</ion-item>
          <ion-item>Fallout</ion-item>
          <ion-item>GTA</ion-item>
          <ion-item>Halo</ion-item>
        </ion-list>

This is the preview, the default in v3 was if there is no lines set the default was a line showing. But we tested it and it seems @Prop lines doesn't have effect on component. Having a look on https://github.com/ionic-team/ionic/blob/master/core/src/components/list/test/inset/index.html it seems we have to set inset not with lines="inset"?

mburger81 commented 6 years ago

I'm closing this issue in favor of #14726

ionitron-bot[bot] commented 6 years ago

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.