search

ionic-team / ionic-framework

A powerful cross-platform UI toolkit for building native-quality iOS, Android, and Progressive Web Apps with HTML, CSS, and JavaScript.
https://ionicframework.com
MIT License
51.08k stars 13.51k forks source link

Proper package for Angular #15191

Closed mhartington closed 5 years ago

mhartington commented 6 years ago

Describe the Bug Right now the ionic/angular is not shipping using the Angular package format. This is creating issues where webpack will pull in ES6 code, when the expected result is to use ES5. Specific example, building out the server side portion of an app with Angular universal will lead to build failures due to ES6 import statements.

Additional Context We should investigate using ng-packagr to properly bundle the angular portion of the library to create the correct format entries.

https://github.com/ionic-team/ionic/issues/14538 https://github.com/ionic-team/ionic/issues/15041

zxdeer commented 6 years ago

ionic4 在beat13 on android5.0 not working

hiepxanh commented 6 years ago

I think it is really important issue. I'm using async, await and it causing my app white screen. ionic 4. beta 15 android 7.

hebra commented 6 years ago

@hiepxanh as mentioned in this ticket #15038 at the moment Android 7.1.1 (patch levels are important!) and the related SDK API version is the minimum required Android version for Ionic 4 to work on Android. The mentioned tickets also suggests a workaround for older versions of Android using the Android System Web View system extension on these devices.

hiepxanh commented 6 years ago

@hebra thank you so much, that help me and other people alot

hiepxanh commented 6 years ago

but the work around using webpack method not working with me, it broking my app

mhartington commented 5 years ago

I think this can be closed for now. @ionic/angular is shipping the correct code needed for Angular's tools to work and for webpack to properly import things.

As it stands the core ionic components get both an ESM build and a ES5 build if the browser supports certain features. As far as using features like async/await, the project build tools will transpile this down to ES5 for browser that don't support it natively.

ionitron-bot[bot] commented 5 years ago

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.