ionic-team / ionic-framework

A powerful cross-platform UI toolkit for building native-quality iOS, Android, and Progressive Web Apps with HTML, CSS, and JavaScript.
https://ionicframework.com
MIT License
50.9k stars 13.52k forks source link

[Core/beta.12] ion-router not working with Firefox in prod mode #15829

Closed kael closed 5 years ago

kael commented 5 years ago

Bug Report

"@ionic/core": "4.0.0-beta.12",
"@stencil/core": "0.13.2"
Firefox 62 - Ubuntu
Chrome 69 - Ubuntu

Describe the Bug When compiled in prod mode, <ion-router/> does nothing in Firefox. Clicking on the Profile Page button from the PWA starter does not trigger navigation

Steps to Reproduce

$ npx create-stencil ionic-pwa ... $ npm run build

Open the app in Chome and Firefox :

Additional Context

There's a NGINX reverse proxy with configured:

location / {
    alias /var/www/html/test/;
}
manucorporat commented 5 years ago

Looks like it's an issue in stencil, already fixed in master https://github.com/ionic-team/stencil/commit/8f17c32bc80060bb2f8baf90a60e0ad56ea9913c

Next version will have it fixed! Thanks

kael commented 5 years ago

Thanks for the quick reply.

Seems something's not working when testing on that commit version:

  "dependencies": {
    "@ionic/core": "4.0.0-beta.12",
    "@stencil/core": "https://github.com/ionic-team/stencil#8f17c32"
  },
    "@stencil/core": {
      "version": "git+https://github.com/ionic-team/stencil.git#8f17c32bc80060bb2f8baf90a60e0ad56ea9913c",
      "from": "git+https://github.com/ionic-team/stencil.git#8f17c32",
      "requires": {
        "chokidar": "2.0.3",
        "jsdom": "11.11.0",
        "typescript": "~2.9.1"
      }
    },
$ npm run build

> @ionic/pwa-toolkit@0.0.1 build /home/kael/dev/test-router
> stencil build

internal/modules/cjs/loader.js:583
    throw err;
    ^

Error: Cannot find module '../dist/cli/index.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:581:15)
    at Function.Module._load (internal/modules/cjs/loader.js:507:25)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/home/kael/dev/test-router/node_modules/@stencil/core/bin/stencil:4:11)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @ionic/pwa-toolkit@0.0.1 build: `stencil build`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @ionic/pwa-toolkit@0.0.1 build script.

Node v10.11.0 NPM 6.4.1

(Tested twice, with rm -rf node_modules/).

kael commented 5 years ago

Any update ? Are you able to reproduce that compilation bug ?

ionitron-bot[bot] commented 5 years ago

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.