search

ionic-team / ionic-framework

A powerful cross-platform UI toolkit for building native-quality iOS, Android, and Progressive Web Apps with HTML, CSS, and JavaScript.
https://ionicframework.com
MIT License
50.98k stars 13.52k forks source link

RC.1 angular build fails in production mode #17034

Closed paulstelzer closed 5 years ago

paulstelzer commented 5 years ago

Bug Report

This issue is fixed already and rc.2 will coming soon!

Ionic version:

[x] 4.0.0-rc.1

Current behavior: rc.1 isn't working in production mode ( ng build --prod / ionic build --prod ). if you run without --prod , everything is working

There are already some issues about (see for there console logs):

Unhandled Promise rejection: c.data is not a function ; Zone: <root> ; Task: Promise.then ; Value: TypeError: c.data is not a function (#17032 / #17033 )

17029

Other errors are:

I will close them so we just have one issue about this topic. It's not only related to @ViewChild(), ion button disabled is also not working and slides only shows the first side

I did some resarch and the issue must be related in #16966. If I build with this PR, production isn't working anymore. I can be wrong, so everyone can do tests too :)

Expected behavior: Should work in production build too

Steps to reproduce:

Add e.g. @ViewChild and try to access to it. Or add a split pane and a menu.

rdlabo commented 5 years ago

icon was not resolved

We must add assets at angular.json in Ionic 4 RC.1. https://github.com/ionic-team/starters/blob/master/angular/base/angular.json#L29-L31

paulstelzer commented 5 years ago

@rdlabo Yes, this is mentioned in the changelog ( https://github.com/ionic-team/ionic/blob/master/CHANGELOG.md#breaking-changes ). But if you run in production mode, icons not working ;)

rdlabo commented 5 years ago

@paulstelzer Oh. Icon worked in production build in my environment... Maybe cache worked..?

paulstelzer commented 5 years ago

did you upload it to your server and tried again (cache cleared)?

eduardoRoth commented 5 years ago

@paulstelzer icons work for me, but I have the error for slides: image

paulstelzer commented 5 years ago

@manucorporat is already working on it and will add some more tests so something like that will hopefully not happen again :)

DreamPWJ commented 5 years ago

We hope to solve the problem as soon as possible. The product must be delivered and launched in these two days, because this problem cannot be used urgently

paulstelzer commented 5 years ago

The problem is already solved. If you need it right now, just fork this repo, install all packages and build it. Then you just need to copy it into your node modules.

orlyapps commented 5 years ago

@paulstelzer I have build @ionic/angular and copied the package into my node_modules. The issue is still there. Im doing something wrong?

paulstelzer commented 5 years ago

could you explain which issue? The ion-slides issue still exist (see #17085 ). But everything else should work, so only thing you can't do is using the slides

Or you revert back to rc.0 if you need a build

orlyapps commented 5 years ago

Yep, the ion-slide issue. Im reverting back to rc.0 - thanks :)

paulstelzer commented 5 years ago

@orlyapps the fix for slides is now integrated in the master branch

orlyapps commented 5 years ago
paulstelzer commented 5 years ago

Everyone who wants to try it out, youcan install the latest dev build by npm install @ionic/angular@dev

ionitron-bot[bot] commented 5 years ago

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.