ionic-team / ionic-framework

A powerful cross-platform UI toolkit for building native-quality iOS, Android, and Progressive Web Apps with HTML, CSS, and JavaScript.
https://ionicframework.com
MIT License
51.02k stars 13.51k forks source link

bug: accessibility failure with ion-button and ion-icon #18272

Closed mhartington closed 3 years ago

mhartington commented 5 years ago

Bug Report

Ionic version:

[x] 4.x

Current behavior:

When running an app through lighthouse, the accessibility audit will point out ion-button and ion-icon for failing to have the proper aria-labels and alt attributes.

Screen Shot 2019-05-13 at 6 42 01 PM
amymarsh4work commented 5 years ago

I just tested 4.7.1 using the forked ionic project, running 'start' in Chrome and Firefox. I tested 4 of the core/button/test pages: basic, dynamic, form and icon using these extensions: Chrome Lighthouse, aXe and WAVE - the specific problem described in this issue no longer exists. :)

jansgescheit commented 5 years ago

I still have a warning at 4.7.1 and the ion-toggle in the Lighthouse's audits

brandyscarney commented 3 years ago

Confirmed this is no longer an issue on latest.

ionitron-bot[bot] commented 3 years ago

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.