ionic-team / ionic-framework

A powerful cross-platform UI toolkit for building native-quality iOS, Android, and Progressive Web Apps with HTML, CSS, and JavaScript.
https://ionicframework.com
MIT License
50.89k stars 13.52k forks source link

Ionic react's hot update plugin USES its own server for hot updates #21131

Closed q5222777 closed 4 years ago

q5222777 commented 4 years ago

Does the ionic react project have plug-ins that can be hot updated? I want this hot update to be done on my own server, similar to the cordova-hot-code-push, but this plugin is no longer available in the ionic4 react project.

Because ionic react's capacitor project doesn't even have config.xml anymore,and Ionic react doesn't have the WWW folder, just the build folder

So can't set in config.xml like: 1587834994940

Are there alternatives?

liamdebeasi commented 4 years ago

Thanks for the issue. Ionic React uses create-react-app under the hood, so any customization will likely need to be done there: https://github.com/facebook/create-react-app.

q5222777 commented 4 years ago

Thanks for the issue. Ionic React uses create-react-app under the hood, so any customization will likely need to be done there: https://github.com/facebook/create-react-app.

I'm asking about the hot update plugin

liamdebeasi commented 4 years ago

We do not manage that plugin, so I do not know if it works with Capacitor. Additionally, the plugin looks to be deprecated: https://github.com/nordnet/cordova-hot-code-push. In general, Cordova plugins mostly work with Capacitor unless they are listed here: https://capacitor.ionicframework.com/docs/cordova/known-incompatible-plugins.

liamdebeasi commented 4 years ago

There is also a plugin provided by Microsoft that looks to be maintained. Not sure if it works for your use case though: https://github.com/Microsoft/cordova-plugin-code-push

edit: looks like someone forked it to add Capacitor support: https://github.com/areo/capacitor-codepush

q5222777 commented 4 years ago

There is also a plugin provided by Microsoft that looks to be maintained. Not sure if it works for your use case though: https://github.com/Microsoft/cordova-plugin-code-push

edit: looks like someone forked it to add Capacitor support: https://github.com/areo/capacitor-codepush

Thanks. I'll try

ionitron-bot[bot] commented 4 years ago

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.