search

ionic-team / ionic-framework

A powerful cross-platform UI toolkit for building native-quality iOS, Android, and Progressive Web Apps with HTML, CSS, and JavaScript.
https://ionicframework.com
MIT License
51.02k stars 13.51k forks source link

bug: ion-toast wrapping wrong when using <b> inside with default --whitespace #21486

Closed RafaelKr closed 3 years ago

RafaelKr commented 4 years ago

Bug Report

Ionic version:

[x] 4.x

Current behavior:

Some time ago I opened an issue which led to the implementation of the --whitespace css variable on ion-toast: https://github.com/ionic-team/ionic/issues/20727

The variable defaults to pre-wrap. This can lead to a "display bug" which I described in the mentioned issue. The problem is that in most cases the developer won't even know that this bug exists as it only appears on specific screen sizes/breakpoints. So he won't change the --white-space variable.

Expected behavior:

Please consider to update the default value to --white-space: normal in the next major release of Ionic as it is much more natural behavior.

Steps to reproduce:

See my other issue for a visual explanation: https://github.com/ionic-team/ionic/issues/20727

liamdebeasi commented 3 years ago

Resolved via https://github.com/ionic-team/ionic-framework/pull/22866.

edit: Forgot to clarify that this will be the next major release of Ionic Framework since it is a breaking change. Thanks!

ionitron-bot[bot] commented 3 years ago

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.