Open EinfachHans opened 3 years ago
Thanks for the issue.
Issue 1 is that WebKit issue that causes scrolling to be reset: https://bugs.webkit.org/show_bug.cgi?id=209968. The good news is that this has been fixed and will be in an upcoming version of iOS!
Issue 2 probably needs an adjustment to the pull to refresh threshold for showing/hiding the spinner.
This issue has been labeled as help wanted
. This label is added to issues that we believe would be good for contributors.
If you'd like to work on this issue, please comment here letting us know that you would like to submit a pull request for it. This helps us to keep track of the pull request and make sure there isn't duplicated effort.
For a guide on how to create a pull request and test this project locally to see your changes, see our contributing documentation.
Thank you!
@liamdebeasi just looked into this. The "native feeling" can easily set by setting a z-index
on the scrollEl of the IonContent, that should be higher than the one of the native refresher (currently 1). Is there a reason why IonContent's scrollEl doesn't have a z-index
? Can it be easily added?
If we add a higher z-index on the scrollEl in ion-content
, wouldn't that end up covering the refresher entirely?
@liamdebeasi This is the Refresher like it is at the moment (without z-index
specified on scrollEl of ion-content and with z-index
1
on refresher-native):
This is with setting z-index
of refresher-native to 0
and the one of ion-content's scrollEl to 1
:
Thanks for the issue.
Issue 1 is that WebKit issue that causes scrolling to be reset: https://bugs.webkit.org/show_bug.cgi?id=209968. The good news is that this has been fixed and will be in an upcoming version of iOS!
Issue 2 probably needs an adjustment to the pull to refresh threshold for showing/hiding the spinner.
@liamdebeasi For Issue 1 I can confirm this issue still happens. I'm testing it with iOS 12 and iOS 14.5 and it's still there. Your workaround (https://github.com/ionic-team/ionic-framework/issues/21291#issuecomment-629244683) works partially, if I go all the way down the refresher "bumps" and the spinner is put on top of the content (kind of like on android), and then it doesn't disappear.
Is this still relevant?
@mikelhamer yes, it is
Thanks. I'm a big lost trying to wrap my head around what the current state of the issue is / what needs to be addressed. I want to help, but not sure where to start.
Bug Report
It MAY be related to #21291, if so pls close. But the behaviour is different, so i'm opening it to be sure
Ionic version:
[ ] 4.x [x] 5.x
Current behavior:
Please have a look into the attached video:
Expected behavior:
Reproduction / Video:
Video: Uploaded here
Repo of the App seen in the video: https://github.com/EinfachHans/ion-refresher-bug2
Other information:
Ionic info (of the test repo):