Closed rdlabo closed 2 years ago
Thanks for the issue. I can definitely understand how this new behavior is unexpected. However, Ionic is working as intended here.
Prior to the fix in https://github.com/ionic-team/ionic-framework/pull/25746, the ion-footer
incorrectly had safe area padding on the bottom when used inside of tabs with a tab bar. The functionality that is being described here was built on the assumption that ion-footer
would always have the safe area in tabs. As a result, when the ion-footer
bug was fixed, the described functionality broke.
I will also note that we do not recommend the pattern that is described in this thread. Instead, we recommend rendering a route outside of the tabs context if developers want the tab bar to be hidden. Moving to that pattern should resolve the issue. Alternatively, you could manually add the safe area padding in your application if you would prefer not to move to the new pattern:
ion-footer ion-toolbar:last-of-type {
padding-bottom: var(--ion-safe-area-bottom, 0);
}
I am going to close this as this is not a bug in Ionic.
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.
Prerequisites
Ionic Framework Version
Current Behavior
https://github.com/ionic-team/ionic-framework/pull/25746 is removed toolbar bottom padding if tab-bar[style="display: none"].
The solution of not displaying the tab-bar on the page after the push transition is often used.
This is reproduced in v6.2.3.
Expected Behavior
if tab-bar[style="display: none"], toolbar has bottom padding.
Steps to Reproduce
Add code to tabs.page.ts to control the display of the tab bar.
Then add a child page with a push transition and add ion-footer to reproduce.
Code Reproduction URL
No response
Ionic Info
Additional Information
No response