bug: ios segment should scale entire button when activated

ionic-team / ionic-framework

A powerful cross-platform UI toolkit for building native-quality iOS, Android, and Progressive Web Apps with HTML, CSS, and JavaScript.

https://ionicframework.com

MIT License

50.93k stars 13.51k forks source link

bug: ios segment should scale entire button when activated #26825

Open xnousnow opened 1 year ago

xnousnow commented 1 year ago

Prerequisites

[X] I have read the Contributing Guidelines.
[X] I agree to follow the Code of Conduct.
[X] I have searched for existing issues that already include this feature request, without success.

Describe the Feature Request

[ ] The label in the segment should get smaller when you press and hold it.
[ ] The white switch that indicates the selection (I don't know what can I call that) when you press and hold it is different: Although the feature is good, I found a difference between native and ionic.

Describe the Use Case

This is just a design suggestion, so the use case is the same.

Describe Preferred Solution

Resolving the above issue.

Describe Alternatives

No response

Related Code

No response

Additional Information

No response

liamdebeasi commented 1 year ago

Thanks for the report. Can you please clarify the issue you are seeing? The segment button in Ionic scales down when you press and hold. Or are you reporting that the scale itself is different from what native does?

DwieDima commented 1 year ago

yeah i can confirm the scale on press is slightly larger on ion-segment. Also ion-segment-button borders are not aligned with ion-segment border when pressed like on ios. Furthermore the text inside ion-segment-button doesnt transforms on change.

IOS normal

IOS pressed

Ionic normal

Ionic pressed

xnousnow commented 1 year ago

For clarify:

https://user-images.githubusercontent.com/119923091/220217342-3a4f5918-7a1a-479e-a658-f3f12c006144.MP4

DwieDima commented 1 year ago

yeah i can confirm the scale on press is slightly larger on ion-segment. Also ion-segment-button borders are not aligned with ion-segment border when pressed like on ios. Furthermore the text inside ion-segment-button doesnt transforms on change.

IOS normal

IOS pressed

Ionic normal

Ionic pressed

Hi @liamdebeasi, i have edited my comment to also include segment button text transform on change to my description. Will this also be included in this ticket?

https://user-images.githubusercontent.com/26873275/220342194-b6b5ec4a-4c3f-4de4-9982-53f98b265b5a.mov

liamdebeasi commented 1 year ago

We will align with the iOS spec as closely as possible when working on this task.