ionic-team / ionic-framework

A powerful cross-platform UI toolkit for building native-quality iOS, Android, and Progressive Web Apps with HTML, CSS, and JavaScript.
https://ionicframework.com
MIT License
50.47k stars 13.53k forks source link

feat(chip): set default shape to soft for ios and md theme and round for ionic theme #29375

Closed brandyscarney closed 1 week ago

brandyscarney commented 3 weeks ago

Issue number: internal


What is the current behavior?

The shape property defaults to undefined which evaluates to the "Soft" shape for the ionic theme and the "Round" shape for the ios/md themes.

Property Value CSS Value (ionic) CSS Value (ios) CSS Value (md)
undefined 4px 16px 16px
"round" 999px unsupported unsupported
"rectangular" 0px unsupported unsupported

What is the new behavior?

Property Value CSS Value (ionic) CSS Value (ios) CSS Value (md)
"soft" 4px 10px 8px
"round" 999px 999px 999px
"rectangular" 0px 0px 0px

Does this introduce a breaking change?

BREAKING CHANGE:

The border-radius of the ios and md chip now defaults to 10px and 8px, respectively, instead of 16px in accordance with the iOS and Material Design 3 guidelines. To revert to the previous appearance, set the shape to "round", or override the --border-radius CSS variable to specify a different value.

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 6:10pm