ionic-team / ionic-framework

A powerful cross-platform UI toolkit for building native-quality iOS, Android, and Progressive Web Apps with HTML, CSS, and JavaScript.
https://ionicframework.com
MIT License
50.47k stars 13.53k forks source link

chore(theming): remove Sass default flags #29401

Closed liamdebeasi closed 2 weeks ago

liamdebeasi commented 2 weeks ago

Issue number: N/A


What is the current behavior?

Currently, every Sass variable in Ionic has the !default flag added to the end.

From the Sass variables documentation:

Normally when you assign a value to a variable, if that variable already had a value, its old value is overwritten. But if you’re writing a Sass library, you might want to allow your users to configure your library’s variables before you use them to generate CSS.

To make this possible, Sass provides the !default flag. This assigns a value to a variable only if that variable isn’t defined or its value is null. Otherwise, the existing value will be used.

In past versions of Ionic Framework, developers wrote Sass variables to rebuild Ionic Framework using their own values. In the latest versions of Ionic Framework, this is not possible.

What is the new behavior?

Removes the !default flag from all Sass variables.

Does this introduce a breaking change?


Co-authored-by: brandyscarney brandyscarney@users.noreply.github.com

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 7:44pm