ionic-team / ionic-framework

A powerful cross-platform UI toolkit for building native-quality iOS, Android, and Progressive Web Apps with HTML, CSS, and JavaScript.
https://ionicframework.com
MIT License
50.63k stars 13.51k forks source link

bug: regression: `ion-textarea` does not follow `dir` #29577

Open AmitMY opened 3 weeks ago

AmitMY commented 3 weeks ago

Prerequisites

Ionic Framework Version

v8.x

Current Behavior

an ion-textarea with dir="auto" for Hebrew and Arabic, i son the left: image

Expected Behavior

until a few weeks ago, it was on the right: image

Steps to Reproduce

  <ion-textarea
    id="mobile"
    rows="1"
    dir="auto"></ion-textarea>

Code Reproduction URL

https://github.com/sign/translate

Ionic Info

Ionic:

Ionic CLI : 7.2.0

Utility:

cordova-res : 0.15.4 native-run : 2.0.1

System:

NodeJS : v22.0.0 npm : 10.5.1 OS : macOS Unknown

Additional Information

Current version 8.2.0

brandyscarney commented 2 weeks ago

Thank you for the issue! Could you please provide a minimal reproduction of the issue? It's hard to see the problem when it is inside of an application. I have created a StackBlitz example here that you could fork and edit to show the problem: https://stackblitz.com/edit/mcqhu5?file=index.html

Alternatively, you can open a StackBlitz from any of our textarea documentation demos, fork them and modify them to show the problem. Thank you. 🙂

ionitron-bot[bot] commented 2 weeks ago

Thanks for the issue! This issue has been labeled as needs reproduction. This label is added to issues that need a code reproduction.

Please reproduce this issue in an Ionic starter application and provide a way for us to access it (GitHub repo, StackBlitz, etc). Without a reliable code reproduction, it is unlikely we will be able to resolve the issue, leading to it being closed.

If you have already provided a code snippet and are seeing this message, it is likely that the code snippet was not enough for our team to reproduce the issue.

For a guide on how to create a good reproduction, see our Contributing Guide.

AmitMY commented 2 weeks ago

hi @brandyscarney ! long time

in this picture, it is auto, rtl, and auto. the first line should behave like the second. image

but dir=auto does not propagate to the child element image

Please see https://stackblitz.com/edit/mcqhu5-2q1unz?file=index.html

brandyscarney commented 2 days ago

Hey @AmitMY! It has been, good to see your name pop up! Sorry for taking so long to get back to you. I was on vacation last week. 🙂

Thanks for the updated StackBlitz. Do you remember when this regression started? Was it after a version update? I am seeing the same thing on v7: https://stackblitz.com/edit/mjxbz3?file=index.html

AmitMY commented 2 days ago

Not sure, possibly it was in ionic 6. I have a screenshot service for my app (fastlane etc) and the current/expected behavior images are from it. that's where i noticed the bug.

Regardless of being a regression then, it is still a bug in v8 :(