fix(modal): fix enter animation when the initial breakpoint value is less than the backdrop breakpoint

ionic-team / ionic-framework

A powerful cross-platform UI toolkit for building native-quality iOS, Android, and Progressive Web Apps with HTML, CSS, and JavaScript.

MIT License

51.13k stars 13.5k forks source link

Issue number: internal

What is the current behavior?

This PR aims to fix an issue introduced in https://github.com/ionic-team/ionic-framework/pull/29932 where the enter animation for ionic theme was in a broken state when the modal's initial breakpoint value was lesser than the specified backdrop breakpoint.

What is the new behavior?

The erroneous behaviour happened because the shouldShowBackdrop constant had a false value which was being taken into consideration when computing the backdrop opacity for the ionic theme. This PR fixes this by always transitioning the backdrop opacity from 0 to 0.7 once the modal appears, independently of the initial, current or activation breakpoint.

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

Name	Status	Preview	Comments	Updated (UTC)
ionic-framework	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 22, 2024 1:54pm

Name

Status

Preview

Comments

Updated (UTC)

ionic-framework

✅ Ready (Inspect)

Visit Preview

💬 Add feedback

Oct 22, 2024 1:54pm

ionic-team / ionic-framework