ionic-team / ionic-framework

A powerful cross-platform UI toolkit for building native-quality iOS, Android, and Progressive Web Apps with HTML, CSS, and JavaScript.
https://ionicframework.com
MIT License
51.13k stars 13.5k forks source link

fix(overlays): do not hide root when toast appears #29962

Closed thetaPC closed 1 month ago

thetaPC commented 1 month ago

Issue number: stemmed from #29773


What is the current behavior?

Certain Chrome and Edge versions (confirmed: Chrome v127, v128, v129 and Edge v127) would indicate that certain elements have an accessibility violation:

Blocked aria-hidden on a "ELEMENT NAME" element because the element that just received
focus must not be hidden from assistive technology users. Avoid using aria-hidden on a
focused element or its ancestor. Consider using the inert attribute instead, which will also
prevent focus. For more details, see the aria-hidden section of the WAI-ARIA specification at

This issue happens when a toast appears and the users clicks on any element that is not related to toast. This is due to the main content having an aria-hidden so users should not to be able to interact with any of those elements. This isn't an issue when an overlay uses a backdrop, like ion-alert because the backdrop prevents a user from interacting with those elements.

What is the new behavior?

Does this introduce a breaking change?

Other information

Dev build: 8.3.4-dev.11729879684.1ea28919

  1. Clone this repo
  2. Install deps
  3. Run the app on a private browser (Chrome v127, v128, v129 or Edge v127)
  4. Open browser console
  5. Click on "Open Toast" button
  6. Click on any element other than "Open Toast" button, like "Open Popover"
  7. Notice the error message
  8. Close private browser
  9. Install dev build: npm install @ionic/angular@8.3.4-dev.11729879684.1ea28919
  10. Repeat steps 4-7
  11. Verify that the error message doesn't occur
vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 6:03pm