search

ionic-team / ionic-framework

A powerful cross-platform UI toolkit for building native-quality iOS, Android, and Progressive Web Apps with HTML, CSS, and JavaScript.
https://ionicframework.com
MIT License
51.11k stars 13.5k forks source link

bug(a11y): ion-input-password-toggle has hardcoded aria-label that cannot be customized #30004

Open 5im0n opened 2 weeks ago

5im0n commented 2 weeks ago

Description

The ion-input-password-toggle component currently has a hardcoded aria-label for the password visibility toggle button. This aria-label cannot be customized, which makes it challenging to adapt the component for different languages and accessibility needs.

Expected Behavior

There should be a way to customize the aria-label for the password toggle button in the ion-input-password-toggle component, allowing developers to set an accessible and localized label.

https://github.com/ionic-team/ionic-framework/blob/4bffe976d937e21c42649d010ce696b19962f6ef/core/src/components/input-password-toggle/input-password-toggle.tsx#L130C11-L130C37