search

ionic-team / ionic-ion-drawer

A side menu drawer for Ionic apps
51 stars 84 forks source link

Fix for closing problem from the right #12

Open kel-sakal-biyik opened 9 years ago

kel-sakal-biyik commented 9 years ago

If you choose to place the drawer to the right by using side attribute, while dragging the drawer to close it, it closes to the left again.

Yuripetusko commented 9 years ago

It works. But not ideally. For example once it is opened if I try to slide it back, it just dissapears instead of transitioning. Also I cannot drag it back.

Have a look at my code. I know it is ugly, I just did a quick fix specific for my case. I need to clean it up and do PR someday. https://github.com/Yuripetusko/ionic-ion-drawer/commits/master

kel-sakal-biyik commented 9 years ago

Strange. It should go away with transition. I will check again. I will also check yours. Thanks!

kel-sakal-biyik commented 9 years ago

Here I have created a pen: http://codepen.io/kel-sakal-biyik/pen/QwzGYe

If you decrease the width of the viewport, transition should also work.

Yuripetusko commented 9 years ago

Hello. I created a PR of my won for the same issue. https://github.com/driftyco/ionic-ion-drawer/pull/13