ionic-team / ionic-native-google-maps

Google maps plugin for Ionic Native
Other
221 stars 125 forks source link

Animations are not show after call a setDiv(). #253

Closed zarelint closed 4 years ago

zarelint commented 4 years ago

I'm submitting a ... (check one with "x")

If you choose 'problem or bug report', please select OS: (check one with "x")

Current behavior: On ionic project, we call setDiv() to get out of the page,for deattach de map. From a commit post below it can not be seen the out of page transition anymore it means the page don't slide to left. (see video)

Expected behavior: After call a setDiv(), we expect the plugin dont do hard dom refresh and let run the animations transitions again as before the commit

This commit has broken it, forcing a complet redraw dom https://github.com/mapsplugin/cordova-plugin-googlemaps/commit/4ef4e5ce68716f1a916f5138ff745d7ed9523f76

i've try a more conservative approach removing these lines:

div.style.display = 'none';
div.offsetHeight;
div.style.display = '';

for this one:

document.body.style.transform = 'rotateZ(0deg)'; I see the animations again but the screen is in black si need other approach

Screen capture or video record:

[ [demo.mp4.zip](https://github.com/ionic-team/ionic-native-google-maps/files/3647203/demo.mp4.zip) ]
wf9a5m75 commented 4 years ago

Please share your project files on GitHub repository, not zip file

zarelint commented 4 years ago

sorry i upload here by error i reopened on googlemaps github. Admin please close this issue here. Thanks !!!