Wrong Error when no map target can be found

ionic-team / ionic-native-google-maps

Google maps plugin for Ionic Native

Other

221 stars 125 forks source link

Wrong Error when no map target can be found #260

Closed de-robat closed 4 years ago

de-robat commented 4 years ago

https://github.com/ionic-team/ionic-native-google-maps/blob/e7bf28c157e17323cd4c5a37e2fecb4d19440e76/src/%40ionic-native/plugins/google-maps/index.ts#L2493

the last "OR" is probably not intentionally written without parenthisis. It gets evaluated even if targets are of length 0 this way and hides the correct error message. Or am i missing something here?

wf9a5m75 commented 4 years ago

If you find something, please send a pull request

de-robat commented 4 years ago

ofc. here you are. https://github.com/ionic-team/ionic-native-google-maps/pull/261