search

ionic-team / ionic-native-google-maps

Google maps plugin for Ionic Native
Other
221 stars 125 forks source link

Fix `Map.setDiv` with an HTMLElement #327

Closed ranma42 closed 3 years ago

ranma42 commented 3 years ago

Currently the setDiv method always fails if it is performed on an element which belongs to the document body, because of an inverted check.

The check can be trivially fixed. Should we also handle explicitly the case in which there is no offsetParent (as in the Map constructor?)

wf9a5m75 commented 3 years ago

Oops. Thank you.