search

ionic-team / ionic-package-hooks

Cordova hooks that you can run in Ionic Package
Other
68 stars 38 forks source link

Implementation question #12

Closed divyekhanna closed 8 years ago

divyekhanna commented 8 years ago

Hi,

I would like to clarify something (got a bit confused in the readme):

Any file (hook) in the root of this repo could be used as a hook during ionic package? using the following: <hook type="after_prepare" src="package-hooks/<hook_file_name>" /> Without adding any file to my local (development) repository?

So, if I require to run a hook to solve a particular problem, I should submit it as a hook file in a PR to this repo?

Thanks!

EDIT: Also, how can we confirm if a package hook ran during ionic package or not?

imhoffd commented 8 years ago

That's correct. The package hooks are already installed on all the package servers.

Right now there's no way to confirm that a hook ran.

Keep in mind, by adding the <hook> to your config.xml, you are also making your local cordova look for the hook when you build your app on your own computer. There are installation instructions to run these hooks locally. If they run locally, Ionic Package should have no problem running them.

divyekhanna commented 8 years ago

Ok, thanks for the clarification