ionic-team / ionic-package-hooks

Cordova hooks that you can run in Ionic Package
Other
68 stars 38 forks source link

Ability to provide custom hooks? #18

Closed joshgarwood closed 8 years ago

joshgarwood commented 8 years ago

Hi there!

I'm not sure if this is possible, but I am trying to include a Push Notification icon (for Android) with my ionic package build to ensure I don't just get a white square.

I have the proper icon in the /resources folder along with my app icons generated through ionic resources. I also have an after_prepare hook that will copy the notification icon into the proper platform/android/res folder, but I can't seem to use it with ionic package.

So my question is, is it possible to supply a custom hook for use with ionic package? Or, if not, is there a way for me to include the push notification icon in the build that gets sent to ionic package?

Thanks!

imhoffd commented 8 years ago

@joshgarwood Just so we're clear, we're talking about the icon, right? Not the image that Android supports? See https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#images

joshgarwood commented 8 years ago

Hey @dwieeb ! Yes, I'm referring to the icon that gets a white mask applied it to in newer versions of Android.

As well, I'm not sure if it makes a difference but I'm not using phonegap-plugin-push for push notifications in this project. I'm using Urban Airship.

Thanks for the quick response!

imhoffd commented 8 years ago

@joshgarwood Ah, sorry, I think I misinterpreted your original issue anyway. Have you seen this? I think it's exactly what you're looking for: https://github.com/driftyco/ionic-package-hooks/pull/14

joshgarwood commented 8 years ago

Yuuup! I think once that bad boy gets merged I'll be good to go. I just added a "watch" on it, so i'll get notified once it's been updated. Thanks again!

imhoffd commented 8 years ago

Cool! I might take a look at accelerating that PR. =) Closing this!

imhoffd commented 8 years ago

@joshgarwood The PR has been merged in. You should be able to use that hook now.

joshgarwood commented 8 years ago

Works like a charm! Thanks so much!

imhoffd commented 8 years ago

Awesome! 👍