Add support for custom themes.xml and styles.xml

ionic-team / ionic-package-hooks

Cordova hooks that you can run in Ionic Package

Other

68 stars 38 forks source link

Closed Just-Ghali closed 8 years ago

Just-Ghali commented 8 years ago

This hook copies files in resources/android/values/ to platforms/android/res/values.

We ran into this limitation when we wanted add custom styles and theme for the android app. Android Styles and Themes

imhoffd commented 8 years ago

Thanks, this looks very good!

Couple things:

No need for console.log (you can comment them out if you like)
Instead of copying every file, can we just copy XML files (or better yet files named themes.xml or styles.xml?) The build breaks if there's any additional files in the values folder.

Just-Ghali commented 8 years ago

Thanks @dwieeb , yep makes sense. I added a check to match against the file name limiting it to themes.xml and styles.xml

imhoffd commented 8 years ago

Thanks, @Just-Ghali! Looks great. I just merged it in.