search

ionic-team / ionic-package-hooks

Cordova hooks that you can run in Ionic Package
Other
68 stars 38 forks source link

Look for the config files in www #25

Closed rolandjitsu closed 7 years ago

rolandjitsu commented 7 years ago

This adds an extra location to look for the firebase config files. Because the ionic package command only uploads www, package.json, config.xml and resources paths to the cloud, we need to place the config files in www.

The copy config from app-scripts can copy the config files from root to www so we don't need to keep anything in www in VC.

rolandjitsu commented 7 years ago

@dwieeb this PR adds an extra location where the hook should search for config files. I explained in my prev PR why it wouldn't work otherwise.

imhoffd commented 7 years ago

Hmm, I wish there was a better way, but this makes sense for today.

imhoffd commented 7 years ago

Thanks!

rolandjitsu commented 7 years ago

@dwieeb Yes, me too. I tried to brainstorm some other ways this could be achieved. In the previous PR I added some comments.