search

ionic-team / ionic-package-hooks

Cordova hooks that you can run in Ionic Package
Other
68 stars 38 forks source link

convert hook to node module. #8

Closed carson-drake closed 8 years ago

carson-drake commented 8 years ago

Proposed fix to #7 .

imhoffd commented 8 years ago

Since we're returning a promise, can we not have synchronous operations within the promise? Let's try just using appendFile instead of appendFileSync. Should be a quick fix and not tie up Cordova during I/O.

carson-drake commented 8 years ago

Agreed, I'll convert it to best practices. It was more of a proof of concept. Probably a little early for a PR.

imhoffd commented 8 years ago

Seems to work! Thanks