search

ionic-team / ionic-paging-animation-app

An Ionic app that shows off a cool pagination effect. Inspired by Ramotion's work https://dribbble.com/Ramotion
11 stars 4 forks source link

Reason for having dedicated provider classes ? #1

Closed ksachdeva closed 8 years ago

ksachdeva commented 8 years ago

Hi Dan,

Was going through the various files in util folder related to Gestures and could not understand the significance and value of having provider classes. At present these provider classes are simply wrapping the respective gesture classes.

You should be able to put Injectable() on the gesture class itself.

Most likely missing the use case and reason

Please educate

Regards & thanks Kapil

danbucholtz commented 8 years ago

Hi @ksachdeva,

We're looking into that. I went ahead and removed the gesture classes as they snuck into this app via and copy and paste error. Thanks for checking out the project and for the tip!

Thanks, Dan

yozman commented 6 years ago

@danbucholtz which dribbble is this? could u plz tell me?